Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: Add new peer-log-format options #1208

Merged
merged 5 commits into from
Feb 28, 2025
Merged

P2P: Add new peer-log-format options #1208

merged 5 commits into from
Feb 28, 2025

Conversation

heifner
Copy link
Member

@heifner heifner commented Feb 27, 2025

  • Add new options _peer and _nver to peer-log-format.
    • _peer - The configured p2p-peer-address or reported address if incoming.
    • _nver - The P2P network protocol version of the connection. e.g. 9 is proto_savanna, 10 is proto_block_nack.
    • Changed the default to use _peer instead of _name as _peer is easier to correlate with configured p2p-peer-address.
  • Add log when not sending a block because connection is busy sending already.

@heifner heifner requested review from greg7mdp and linh2931 February 27, 2025 14:28
@heifner heifner added the OCI Work exclusive to OCI team label Feb 27, 2025
@heifner heifner added this to the Spring v1.2.0-rc1 milestone Feb 27, 2025
greg7mdp
greg7mdp approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@greg7mdp greg7mdp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be cleaner to have another enqueue_buffer version, which doesn't take a std::optional<block_num_type> block_num, but which calls the other one with std::nullopt. But fine as it is if you prefer.

Base automatically changed from p2p-1mb-buffer to main February 27, 2025 19:26
@heifner heifner merged commit 7ff06d2 into main Feb 28, 2025
36 checks passed
@heifner heifner deleted the p2p-logging branch February 28, 2025 13:29
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: P2P
summary: Add new options _peer and _nver to peer-log-format.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
Spring v1.2.0-rc1
Development

Successfully merging this pull request may close these issues.
4 participants
@heifner @ericpassmore @greg7mdp @linh2931